fix toggle bottom panel to align to vscode #10147
Conversation
Signed-off-by: shuyaqian [email protected]
There was a problem hiding this comment.
However, in vscode, the terminal icon on the bottom status bar is always there.
I was unable to see the bottom statusbar item to toggle the bottom panel in vscode, can you clarify?
If there is no bottom panel, we can click the icon to quickly create a terminal.
Given we are a framework we should instead think about providing an API for adopters and extenders to contribute default views to the bottom-panel and open them if the bottom-panel does not exist rather than hardcoding that the terminal should be opened.
| execute: () => { | ||
| if (this.shell.isExpanded('bottom')) { | ||
| if (this.shell.getWidgets('bottom').length === 0) { | ||
| commandRegistry.executeCommand('terminal:new'); |
There was a problem hiding this comment.
@shuyaqian I do not believe that @theia/core should know anything about terminals.
It is possible that applications will also choose to omit the use of terminals (#6645).
vince-fugnitto
added
the
🤔 needs more info
Sorry, I found out that I installed a terminal plugin in vscode. The status bar icon is registered with this plugin. But I have to say, it's really convenient. Intellij has the icon that allow you to quickly create a terminal. |
@shuyaqian if it’s the case then you can include the plugin by default in your custom application as a built-in? I don’t think there’s a need to support it directly in the framework like you’ve done. If it’s necessary you can also create a custom theia extension for your product that contributes the functionality as well. |
Signed-off-by: shuyaqian [email protected]
What it does
When there is no bottom panel, we must create a terminal through the top menu or shortcut keys. However, in vscode, the terminal icon on the bottom status bar is always there. If there is no bottom panel, we can click the icon to quickly create a terminal.
How to test
Review checklist
Reminder for reviewers