electron: fix canRead implementation
#10131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
file dialog
|
@DevTester425 you can test the pull-request if you'd like to confirm it fixes the issue you've experienced. |
packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts
Outdated
Show resolved
Hide resolved
The commit simplifies the `canRead` implementation (used to determine if resources cannot be read), and fixes the issue where the message would not display the correct resource. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/readonly-electron-fix
branch
from
ed81ab9 to
2cbb0f4
Compare
colin-grant-work
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10103
The pull-request updates and simplifies the
ElectronFileDialogService.canReadmethod which previously produced false positive messages to end-users about unreadable resources.The changes should:
open fileoropen folderdialogsHow to test
open fileandopen folderwork correctlyreadonlyfiles can in fact be openedReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]