Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionItemKind: add enum values User and Issue #10123

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Archie27376
Copy link
Contributor

What it does

fixes: #10003
Adds missing enum values to CompletionItemKind in theia.d.ts and types-impl.ts and appropriate convertors.

How to test

N/A

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 16, 2021
@tsmaeder tsmaeder merged commit 8695b1e into eclipse-theia:master Sep 20, 2021
@vince-fugnitto vince-fugnitto deleted the gh10003_fix branch September 20, 2021 12:05
@vince-fugnitto vince-fugnitto added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CompletionItemKind#User and CompletionItemKind#Issue
3 participants