fix electron frontend debug configuration #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
For some reason TS files are loaded as `webpack://@theia/example-electron/*` in Electron's Chrome DevTools, and it confused VS Code's JS debugger. Add a `sourceMapPathOverride` to point the debugger to the right place on disk.
paul-marechal
force-pushed
the
mp/electron-source-map-fix
branch
from
1158abe to
c22381f
Compare
|
If someone knows where this |
vince-fugnitto
added
contributor experience
alvsan09
reviewed
Sep 16, 2021
There was a problem hiding this comment.
I have tested as per instructions and can confirm the solution works! 👍
@paul-marechal, how would you like to proceed as there is an existing proposed fix at #9827?
alvsan09
approved these changes
Sep 16, 2021
vince-fugnitto
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason TS files are loaded as
webpack://@theia/example-electron/*in Electron's Chrome DevTools, andit confused VS Code's JS debugger.
Add a
sourceMapPathOverrideto point the debugger to the right placeon disk.
Closes #9827
How to test
Launch Electron Backend & Frontenddebug configuration.Review checklist
Reminder for reviewers