plugin: fix tree-searching in tree-views #10097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the bogus rebinding of `tree-props` which meant that we are not longer able to `search` as a result. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
bug
msujew
approved these changes
Sep 14, 2021
|
Thanks @vince-fugnitto This actually fixes another bug where context menus on treeviews supplied by plugins don't work. Now they do!
I was about to open a PR and did a git blame only to find you fixed it two days previously 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10095
The pull-request fixes the bogus rebinding of
tree-propswhich meant that we are not longer able tosearchas a result.Instead of rebinding the
props(losing them), we pass them correctly.tree-search-fix.mp4
How to test
npm scriptsviewReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]