Align the menu separator with vscode #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
ui/ux
vince-fugnitto
approved these changes
Sep 10, 2021
msujew
force-pushed
the
msujew/menu-separator
branch
from
45aa30a to
3f30553
Compare
|
FYI @vince-fugnitto I also increased the right-side padding for the menu chevrons so they don't protrude from the menu separators anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Aligns the menu separator with vscode. Includes a lower opacity and margins on the left and right side of the separators. See vscode's menu and Theia's new menu.
How to test
Review checklist
Reminder for reviewers