task: make TaskDefinition required optional

[vince-fugnitto]

What it does

Fixes: #10014

The commit makes TaskDefinition.properties.required optional based on the json schema validation definition. Previously, if an extension defines a schema that omits the required property the application will throw errors and fail to display the menu. The change treats the missing required property as an empty array as per the spec.

How to test

• Follow the steps as described in task: handle possibly missing required property #10014

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[vince-fugnitto]

@tsmaeder any objections?

[tsmaeder]

@vince-fugnitto which schema are we using? https://code.visualstudio.com/api/references/contribution-points#contributes.taskDefinitions seems to indicate that the field is required. Do we have real cases of extensions that fail because of this?

Not objecting to be more lenient than the json schema in what we accept, though.

[vince-fugnitto]

@vince-fugnitto which schema are we using? https://code.visualstudio.com/api/references/contribution-points#contributes.taskDefinitions seems to indicate that the field is required. Do we have real cases of extensions that fail because of this?

@tsmaeder I initially started working on the issue after noticing errors in the console when using vscode-docker:

I believe a real-world example is ms-azuretools.vscode-docker:

• https://github.com/microsoft/vscode-docker/blob/9372dad847505cebac176dd21e8213a5cdf0be14/package.json#L983

In addition, vscode declares the schema like so, so I thought we should be more robust as not to have such errors:

• https://github.com/microsoft/vscode/blob/7392504f85d49732003f1e031c75e63fafae4de2/src/vs/workbench/contrib/tasks/common/taskDefinitionRegistry.ts#L50-L55

[tsmaeder]

In addition, vscode declares the schema like so

So the documentation is lying ;-) Merge away!

[paul-marechal]

LGTM code-wise.