Replace instanceof ThemeIcon with an is method
#10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
Aug 31, 2021
paul-marechal
pushed a commit
that referenced
this pull request
Aug 31, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #10010
Replaces the
instanceofcalls forThemeIconswith anismethod. If anyone knows a better way of fixing this, please comment.Also, there are a few other
instanceofcalls combined withes5Compatibilityannotations, but they seem to work, as far as I can tell.How to test
masterand existing icon on this PR.Review checklist
Reminder for reviewers