A serious performance problem about Disposable

[christlee1989]

Bug Description:

If you call the Disposable.push method multiple times and pass in the same disposable instance, it will cause the "dispose" method to be nested wrapped, which will lead to serious performance problems(Maximum call stack size exceeded).

packages/core/src/common/disposable.ts

packages/core/src/browser/shell/tab-bar-toolbar.tsx

Steps to Reproduce:

1. In the Disposable.push method, mark each wrapped method and record the number of times that the method is wrapped.

in packages/core/src/common/disposable.ts

in packages/core/src/browser/shell/tab-bar-toolbar.tsx

2. After starting the IDE, keep switching editor tabs in the editor area, check the console log, you can see that the number of calls to the wrapped method is increasing
   

Additional Information

• Operating System: macOS 10.15.7
• Theia Version: 1.12.0