Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a security policy to the repo #8795

Closed
luigigubello opened this issue Nov 28, 2020 · 4 comments · Fixed by #9804
Closed

Adding a security policy to the repo #8795

luigigubello opened this issue Nov 28, 2020 · 4 comments · Fixed by #9804
Labels
security issues related to security

Comments

@luigigubello
Copy link

luigigubello commented Nov 28, 2020

Feature Description:

Theia IDE Security Policy

Theia IDE is a popular open-source project, but it misses a policy for reporting vulnerabilities. I think it would be important for people who want to report a critical issue in the right way. In addition, I suggest tracking critical bugs in the Github security advisories section (e.g. Will issue #7954 receive a CVE?).

Thank you

Best regards

@kittaakos
Copy link
Contributor

@marcdumais-work, can set up security policies in this repo? Does the Eclipse community have such a template that we can reuse as-is?

@luigigubello
Copy link
Author

If you want, I can help to write a draft CVD policy for the Theia repo. At the moment, Eclipse Foundation has a generic security policy, maybe we can adapt it to this repo. I suggest tracking Theia IDE security issues also using Github security advisories.

@marcdumais-work
Copy link
Contributor

I suggest tracking Theia IDE security issues also using Github security advisories.

@luigigubello I guess it depends what you have in mind exactly. I agree that currently it's not easy for a visitor to this repo, to find what to do, in case they found a security vulnerability. If you can propose a PR that helps with that, great.

Theia is an Eclipse Foundation project, and they set the high-level security policy that we have to follow. So your draft should explicitly point-to and extend the Foundation's security policy, not try replace it. In case of doubt, I can have them have a look.

sounds like a plan?

@luigigubello
Copy link
Author

luigigubello commented Nov 30, 2020

Theia is an Eclipse Foundation project, and they set the high-level security policy that we have to follow.

Eclipse Foundation's security policy seems to be good, but I'm not clear how security issues are tracked at the moment. I mean, in the policy I read:

All Vulnerabilities must be disclosed, regardless of the resolution.

I think this point is really important, Github security advisories don't have to replace the Eclipse Foundation bug tracking, but they can be a user-friendly mirror. So, my question is: how are security issues tracked and disclosed at the moment? Both fixed and open bugs. I mean, I have this list:

Security issues:

Is there a way to track them? (CVE or GH advisories or Eclipse Foundation bug ID, just be public)

@marcdumais-work I will open a PR for suggesting a policy for this repo, it will be based on Eclipse Found. policy, but I think this project needs a better vulnerabilities tracking. Do you agree? Can we work together to improve this security process? :)

This was referenced Dec 9, 2020
@vince-fugnitto vince-fugnitto added the security issues related to security label Mar 5, 2021
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template to make it clear it's
not to be used to report security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modify bug report issue template and PR template to make it
clear they're not to be used to disclose security vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
Also modified the GitHub bug report issue template and PR template,
to make it clear they're not to be used to disclose security
vulnerabilities.

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
As part of our periodic Eclipse Foundation project review (1), we are
encouraged to add a security policy file, for our project. I went with
the miminal amount of information I thought was needed, not duplicating
info from the EF policy. It should be a good first step, I think.

In addition, I also modified the GitHub bug report issue template and PR
template, to make it clear they're not meant to be used to disclose security
vulnerabilities.

A nice side-effect of adding SECURITY.md is that GitHub automatically adds
an entry in our issue-submission page: "Report a security vulnerability",
that has a button "View Policy" that opens our policy.

There are some more seemingly nice GitHub project security features that,
could be enabled for our repo/project (with webmaster's help). We can
consider them separately.

(1): https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/64

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue Jul 29, 2021
As part of our project's periodic Eclipse Foundation progress review (1),
we are encouraged to add a security policy file, for our project. I went
with the miminal amount of information I thought was needed, not duplicating
info from the EF policy. It should be a good first step, I think.

In addition, I also modified the GitHub bug report issue template and PR
template, to make it clear they're not meant to be used to disclose security
vulnerabilities.

A nice side-effect of adding SECURITY.md is that GitHub automatically adds
an entry in our issue-submission page: "Report a security vulnerability",
that has a button "View Policy" that opens our policy.

There are some more seemingly nice GitHub project security features that
could be enabled for our repo/project (with webmaster's help). We can
consider them separately.

(1): https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/64

Fixes #8795

Signed-off-by: Marc Dumais <[email protected]>
@marcdumais-work marcdumais-work mentioned this issue Jul 29, 2021
1 task
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue Jul 29, 2021
As part of our project's periodic Eclipse Foundation progress review (1),
we are encouraged to add a security policy file, for our project. I went
with the miminal amount of information I thought was needed, not duplicating
info from the EF policy. It should be a good first step, I think.

In addition, I also modified the GitHub bug report issue template and PR
template, to make it clear they're not meant to be used to disclose security
vulnerabilities.

A nice side-effect of adding SECURITY.md is that GitHub automatically adds
an entry in our issue-submission page: "Report a security vulnerability",
that has a button "View Policy" that opens our policy.

There are some more seemingly nice GitHub project security features that
could be enabled for our repo/project (with webmaster's help). We can
consider them separately.

(1): https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/64

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue Aug 2, 2021
As part of our project's periodic Eclipse Foundation progress review (1),
we are encouraged to add a security policy file, for our project. I went
with the miminal amount of information I thought was needed, not duplicating
info from the EF policy. It should be a good first step, I think.

In addition, I also modified the GitHub bug report issue template and PR
template, to make it clear they're not meant to be used to disclose security
vulnerabilities.

A nice side-effect of adding SECURITY.md is that GitHub automatically adds
an entry in our issue-submission page: "Report a security vulnerability",
that has a button "View Policy" that opens our policy.

There are some more seemingly nice GitHub project security features that
could be enabled for our repo/project (with webmaster's help). We can
consider them separately.

(1): https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/64

Fixes #8795

Signed-off-by: Marc Dumais <[email protected]>
dna2github pushed a commit to dna2fork/theia that referenced this issue Aug 25, 2021
As part of our project's periodic Eclipse Foundation progress review (1),
we are encouraged to add a security policy file, for our project. I went
with the miminal amount of information I thought was needed, not duplicating
info from the EF policy. It should be a good first step, I think.

In addition, I also modified the GitHub bug report issue template and PR
template, to make it clear they're not meant to be used to disclose security
vulnerabilities.

A nice side-effect of adding SECURITY.md is that GitHub automatically adds
an entry in our issue-submission page: "Report a security vulnerability",
that has a button "View Policy" that opens our policy.

There are some more seemingly nice GitHub project security features that
could be enabled for our repo/project (with webmaster's help). We can
consider them separately.

(1): https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/64

Fixes eclipse-theia#8795

Signed-off-by: Marc Dumais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security issues related to security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants