Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quality][preferences] PreferencesWidget#COMMANDL_LABEL is unused #8201

Closed
kittaakos opened this issue Jul 20, 2020 · 0 comments · Fixed by #8249
Closed

[quality][preferences] PreferencesWidget#COMMANDL_LABEL is unused #8201

kittaakos opened this issue Jul 20, 2020 · 0 comments · Fixed by #8249
Labels
good first issue good first issues for new contributors preferences issues related to preferences quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

Bug Description:

Unused static:

theia/packages/preferences/src/browser/views/preference-widget.tsx

Line 36 in ac06ac9

static readonly COMMAND_LABEL = 'Open Preferences';

The command with the label is already defined in @theia/core:

theia/packages/core/src/browser/common-frontend-contribution.ts

Lines 245 to 249 in ac06ac9

export const OPEN_PREFERENCES: Command = {
id: 'preferences:open',
category: 'Settings',
label: 'Open Preferences',
};

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@kittaakos kittaakos added preferences issues related to preferences quality issues related to code and application quality good first issue good first issues for new contributors labels Jul 20, 2020
minyoungyang added a commit to minyoungyang/theia that referenced this issue Jul 28, 2020
@minyoungyang
[preferences] Unused static variable
c967fa4 
Fixes: eclipse-theia#8201

Deleted unused static (PreferenceWidget.COMMAND_LABEL)

Signed-off-by: Min-young Yang <[email protected]>
@minyoungyang minyoungyang mentioned this issue Jul 28, 2020
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Jul 28, 2020
@minyoungyang @vince-fugnitto
[preferences] Unused static variable
8969486 
Fixes: #8201

Deleted unused static (PreferenceWidget.COMMAND_LABEL)

Signed-off-by: Min-young Yang <[email protected]>
minyoungyang added a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@minyoungyang
[preferences] Unused static variable
27a8894 
Fixes: eclipse-theia#8201

Deleted unused static (PreferenceWidget.COMMAND_LABEL)

Signed-off-by: Min-young Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors preferences issues related to preferences quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[preferences] Unused static variable minyoungyang/theia
1 participant
@kittaakos