Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align TaskScope with API object #7931

Closed
RomanNikitenko opened this issue May 31, 2020 · 4 comments · Fixed by #9032
Closed

Align TaskScope with API object #7931

RomanNikitenko opened this issue May 31, 2020 · 4 comments · Fixed by #9032
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@RomanNikitenko
Copy link
Contributor

I think TaskScope should be aligned with the corresponding object in theia.d.ts and VS Code object

Additional Information
@RomanNikitenko RomanNikitenko added the tasks issues related to the task system label May 31, 2020
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Jun 2, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented Jun 2, 2020

Could you clarify what you mean by "aligned"? What change do you propose?

@RomanNikitenko
Copy link
Contributor Author

I mean we have the difference for Workspace scope:

Theia object from task protocol:

export enum TaskScope {
    Workspace = 0,
    Global = 1
}

Objects from theia.d.ts and vscode.d.ts

export enum TaskScope {
        Global = 1,
        Workspace = 2
    }

@tsmaeder
Copy link
Contributor

tsmaeder commented Jun 2, 2020

Thx, didn't realize that.

@vince-fugnitto
Copy link
Member

@alvsan09 has expressed he'd like to work on the feature 👍

alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 1, 2021
@alvsan09
Align TaskScope with API object
039f5f3 
Align the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 2, 2021
@alvsan09
Align TaskScope with API object
1a5255e 
Align the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 4, 2021
@alvsan09
Align TaskScope with API object
d6b7e6c 
Align the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 5, 2021
@alvsan09
Align TaskScope with API object
3e00b25 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
@alvsan09 alvsan09 mentioned this issue Feb 5, 2021
Merged
1 task
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 9, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
e9e23f5 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 9, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
37c5582 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Feb 23, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
ef7e296 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 2, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
33ac2ea 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 2, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
8a8b052 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 3, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
87128d4 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 8, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
a3bc8f4 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 8, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
680ff5a 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 9, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
14574ba 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this issue Mar 16, 2021
@alvsan09
Support plugin tasks using 'TaskScope.Workspace'
d198a28 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: eclipse-theia#7931

[1] eclipse-theia#7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
vince-fugnitto pushed a commit that referenced this issue Mar 19, 2021
@alvsan09 @vince-fugnitto
Support plugin tasks using 'TaskScope.Workspace'
ca2f87c 
* Aligns the TaskScope enum definition with vscode
see issue [1] and corresponding schemas for Theia [2] and vscode [3]

* Supports processing of task configurations provided by plugins with
the scope set to TaskScope.Workspace.

* Ignores processing of task configurations provided by plugins with
the scope set to TaskScope.Global i.e. User tasks.

Fixes: #7931

[1] #7931
[2] https://github.com/eclipse-theia/theia/blob/2aa2fa1ab091ec36ef851c4e364b322301cddb40/packages/plugin/src/theia.d.ts#L8637
[3] https://github.com/microsoft/vscode/blob/50f907f0ba9b0c799a7c1d2f28a625bf30041636/src/vs/vscode.d.ts#L5923

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support plugin tasks using 'TaskScope.Workspace' alvsan09/theia
4 participants
@akosyakov @RomanNikitenko @tsmaeder @vince-fugnitto