[SIW] The search should not run when input does not change

[kittaakos]

Description

We run the SIW each time the "selection"? changes in the SIW input. It's a bug.

Reproduction Steps

Write something into the SIW input change the cursor location, try to Select All (if you are not in electron).

OS and Theia version:

Diagnostics:

[kittaakos]

We should debounce and use cancellation token

Or we could not run the query when the input does not change. Can we do that instead of debouncing and cancellation?

[akosyakov]

Or we could not run the query when the input does not change. Can we do that instead of debouncing and cancellation?

true, we should not trigger search at all

[akosyakov]

What btw should happen if there are new files? Does search automatically adjust or one has to press enter to rerun. In this case disabling rerunning will break.

[kittaakos]

What btw should happen if there are new files?

We have to do what VS Code does; it does not update the search results on new file creation. Which is what I would expect as a user.

[vince-fugnitto]

I'll close the pre-existing issue in favor of this one since it has additional discussions:

• search-in-workspace: search should not be triggered for all keystrokes #7271

[akosyakov]

We have to do what VS Code does; it does not update the search results on new file creation. Which is what I would expect as a user.

But I see that VS Code runs search again if I press enter and then it finds new results. For changed selection it is for sure bogus though.

[kittaakos]

But I see that VS Code runs search again if I press enter and then it finds new results.

I didn't say it does not re-run the query when you hit enter, I said:

it does not update the search results on new file creation. Which is what I would expect as a user.

I meant automatically.