Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't activate vscode python plugin when opening an ipynb file #7111

Closed
tom-shan opened this issue Feb 10, 2020 · 2 comments · Fixed by #7110
Closed

can't activate vscode python plugin when opening an ipynb file #7111

tom-shan opened this issue Feb 10, 2020 · 2 comments · Fixed by #7110
Assignees
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@tom-shan
Copy link
Contributor

Description

The vscode python plugin is not activated when an ipynb file is opened, so the notbook editor is not showing. Only when a python file is opened first and vscode python plugin is activated successfully, the ipynb file can be opened in notebook editor.

Reproduction Steps

image

OS and Theia version:
OS: centos 7
theia: d5f3262
python plugin: 2020.1.58038
Diagnostics:

Per

() => this.onDidActivateLanguage(language, () => this.monacoTextmateService.activateLanguage(language))
, only the language which contains grammars contaibutions can be activated.

vscode python plugin contains no grammars contribution of jupyter according to:
https://github.com/microsoft/vscode-python/blob/master/package.json#L45
and
https://github.com/microsoft/vscode-python/blob/ead69d5e2e910153e5715b6f4a7abf41f23efac5/package.json#L2778-L2784

@vince-fugnitto
Copy link
Member

@tom-shan does the plugin activate correctly in vscode when first opening a .ipynb file?

@tom-shan
Copy link
Contributor Author

tom-shan commented Feb 10, 2020

@tom-shan does the plugin activate correctly in vscode when first opening a .ipynb file?

yes, it activate correctly

@vince-fugnitto vince-fugnitto added bug bugs found in the application vscode issues related to VSCode compatibility labels Feb 10, 2020
tom-shan added a commit to tom-shan/theia that referenced this issue Feb 10, 2020
tom-shan added a commit to tom-shan/theia that referenced this issue Feb 10, 2020
tom-shan added a commit to tom-shan/theia that referenced this issue Feb 10, 2020
@akosyakov akosyakov self-assigned this Feb 11, 2020
akosyakov added a commit that referenced this issue Feb 11, 2020
akosyakov added a commit that referenced this issue Feb 12, 2020
akosyakov added a commit that referenced this issue Feb 12, 2020
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
3 participants