Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Hierarchy #707

Closed
svenefftinge opened this issue Oct 22, 2017 · 1 comment
Closed

Type Hierarchy #707

svenefftinge opened this issue Oct 22, 2017 · 1 comment
Assignees
@kittaakos
Labels
enhancement issues that are enhancements to current functionality - nice to haves

Comments

@svenefftinge
Copy link
Contributor

A type hierarchy view, should allow a user to follow the inheritance hierarchy of feature calls in a language. It is not supported by the LSP, yet. As part of this we could make a proposal.

As a default implementation, we could try to build it based on references and documentSymbols and some sort of best guess, whether a reference is an inheritance reference. E.g. if it's on the first line of the containing symbol and the symbol is a type definition. Needs investigation if that can be made reliable enough.
@svenefftinge svenefftinge added the enhancement issues that are enhancements to current functionality - nice to haves label Oct 22, 2017
@MarkZ3
Copy link
Contributor

MarkZ3 commented Apr 24, 2018

I'm interested to make this work for C++. On the server side, we can probably do a "parent" hierarchy without too much effort and accurately. So we would not use references/documentSymbols for guessing. It would still be quite useful even though it would just be for discovering parent classes (or method being implemented/overridden).

@kittaakos kittaakos self-assigned this Oct 8, 2018
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707: some progress
72ec253 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:
ce65aad 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:
fc095a3 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:
ac4b14f 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:
5d06eb2 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:Signed-off-by: Akos Kitta <[email protected]>
1aa05b9
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707
bd538a7 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 10, 2018
GH-707:
b34d7ed 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 11, 2018
GH-707: Introduced the @theia/typehierarchy extension.
3dd6c0b 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - TODO...

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 11, 2018
GH-707: Introduced the @theia/typehierarchy extension.
94e1c6a 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - TODO...

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 11, 2018
GH-707: Introduced the @theia/typehierarchy extension.
5e17b8b 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Oct 11, 2018
GH-707: Introduced the @theia/typehierarchy extension.
f853a03 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Oct 11, 2018
Closed
kittaakos pushed a commit that referenced this issue Oct 17, 2018
GH-707: Introduced the @theia/typehierarchy extension.
8bb8545 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Dec 11, 2018
Merged
kittaakos pushed a commit that referenced this issue Jan 23, 2019
GH-707: Introduced the @theia/typehierarchy extension.
d546d26 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jan 23, 2019
GH-707: Introduced the @theia/typehierarchy extension.
380dd03 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jan 25, 2019
GH-707: Introduced the @theia/typehierarchy extension.
1863194 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jan 28, 2019
GH-707: Introduced the @theia/typehierarchy extension.
e99b655 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 5, 2019
GH-707: Introduced the @theia/typehierarchy extension.
6c68603 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.
 - Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 5, 2019
GH-707: Introduced the @theia/typehierarchy extension.
3b726b6 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 6, 2019
GH-707: Introduced the @theia/typehierarchy extension.
7576218 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 6, 2019
GH-707: Introduced the @theia/typehierarchy extension.
79ffbdf 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 6, 2019
GH-707: Introduced the @theia/typehierarchy extension.
890755a 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 6, 2019
GH-707: Introduced the @theia/typehierarchy extension.
1c44854 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 7, 2019
@kittaakos
GH-707: Introduced the @theia/typehierarchy extension.
8ff594a 
 - Extended the LSP with the type hierarchy.
 - From now on, a tree node can carry decoration data.
 - Added editor access for the current/active editors.

Closes: #707.

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarkZ3 @svenefftinge @kittaakos