Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layout restoration] missing file causes restoration to fail #564

Closed
marcdumais-work opened this issue Sep 25, 2017 · 0 comments
Closed
Assignees
Labels
bug bugs found in the application

Comments

@marcdumais-work
Copy link
Contributor

If between two Theia sessions, a file that was initially opened in an editor disappears, the restoration fails completely when Theia is opened again.

It would probably be better that the layout restoration was "best effort" and continued even if a part of it fails.

see #560 for one example where this can happen. But it could probably also happen if a file was unavailable for some other reason (e.g. switched git branch).

localhost/:1 Uncaught (in promise) A resource provider for 'file:///tmp/a/theia/examples/browser/aaa.txt' is not registered.
Promise rejected (async)
(anonymous) @ shell-layout-restorer.ts:78
ShellLayoutRestorer.inflate @ shell-layout-restorer.ts:73
(anonymous) @ shell-layout-restorer.ts:28
Promise resolved (async)
ShellLayoutRestorer.onStart @ shell-layout-restorer.ts:25
FrontendApplication.startContributions @ frontend-application.ts:110
FrontendApplication.start @ frontend-application.ts:67
start @ index.js:29
Promise resolved (async)
Object.defineProperty.value @ index.js:48
__webpack_require__ @ bootstrap a28e50b24baf5c30315c:688
Object.defineProperty.value @ bootstrap a28e50b24baf5c30315c:789
(anonymous) @ bootstrap a28e50b24baf5c30315c:789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application
Projects
None yet
Development

No branches or pull requests

2 participants