Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search-in-workspace] search does not respect dirty changes #5609

Closed
vince-fugnitto opened this issue Jun 28, 2019 · 0 comments · Fixed by #8579
Closed

[search-in-workspace] search does not respect dirty changes #5609

vince-fugnitto opened this issue Jun 28, 2019 · 0 comments · Fixed by #8579
Assignees
@fangnx
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help search in workspace issues related to the search-in-workspace

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jun 28, 2019 •
edited
Loading

Description

The search-in-workspace widget does not respect dirty changes.
If an editor A has dirty changes and the search-in-workspace is used to search such changes, no results are found from A.

a (2)

How to Reproduce

  1. open an editor and make changes (do not save and use a unique string ex: vincent).
  2. open the search-in-workspace widget.
  3. search for the unique string, the search-in-workspace widget will not show the result.
@vince-fugnitto vince-fugnitto added bug bugs found in the application search in workspace issues related to the search-in-workspace labels Jun 28, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jul 1, 2019
@fangnx fangnx self-assigned this Jul 3, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 5, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
7ae52cc 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 8, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
703ea54 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
@lmcbout lmcbout mentioned this issue Jul 8, 2019
Merged
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 12, 2019
@fangnx
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
ad5a9d5 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 12, 2019
@fangnx
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
317c2b8 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 26, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
45baee4 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 29, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
44ba116 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 29, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
5ef79f5 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 29, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
6d5ec2c 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 29, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
699ef0b 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 29, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
ea20317 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 6, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
f0f7f1b 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 23, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
c7841a1 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
@fangnx fangnx mentioned this issue Aug 23, 2019
Closed
8 tasks
fangnx pushed a commit to fangnx/theia that referenced this issue Aug 23, 2019
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
8df251a 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
vince-fugnitto pushed a commit to fangnx/theia that referenced this issue Sep 4, 2019
@vince-fugnitto
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
f32cf9e 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
vince-fugnitto pushed a commit to fangnx/theia that referenced this issue Sep 4, 2019
@vince-fugnitto
Fixed eclipse-theia#5609: supported workspace search in dirty (unsave…
367be68 
…d) file content

- The `Search-in-Workspace` now can correctly search content in dirty files (file with unsaved changes).
- Search results in dirty files will be replaced in correct line and character position.
- Implemented by conducting a search in all currently tracked dirty files, before the backend ripgrep search.

Signed-off-by: fangnx <[email protected]>
@DucNgn DucNgn mentioned this issue Oct 1, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangnx fangnx

Labels
bug bugs found in the application help wanted issues meant to be picked up, require help search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
3 participants
@akosyakov @fangnx @vince-fugnitto