[navigator] some icons & names are not aligned

[fangnx]

As the screenshot shows, icons and labels of package.json and README.md are not aligned properly.

[vince-fugnitto]

I wonder if we should think about dropping our file-icon.js support for the vscode's icons.
https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons

https://code.visualstudio.com/blogs/2016/09/08/icon-themes

It's not only our vertical spacing that is off but also our horizontal (notice the 'README' label is pushed more to the right than other files).

[fangnx]

I wonder if we should think about dropping our file-icon.js support for the vscode's icons.
https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons

https://code.visualstudio.com/blogs/2016/09/08/icon-themes

It's not only our vertical spacing that is off but also our horizontal (notice the 'README' label is pushed more to the right than other files).

Seems like the icons all have different width and length. Is it because we used icons from vs code but did not resize them?

[vince-fugnitto]

I think in general it's how the icons are, they have their own height and width which may differ and we give them all consistent font-sizes, so in the end the icons are not properly normalized to each other.

[vince-fugnitto]

I think this issue is already fixed.

Unfortunately it is still an issue :(
See how the filenames are not aligned (this happens due to the alignment of icons)