Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-experience][windows] Investigate whether we can enable parallel execution with Lerna #4532

Closed
kittaakos opened this issue Mar 12, 2019 · 0 comments · Fixed by #6893
Closed

[dev-experience][windows] Investigate whether we can enable parallel execution with Lerna #4532

kittaakos opened this issue Mar 12, 2019 · 0 comments · Fixed by #6893
Labels
OS/Windows issues related to the Windows OS

Comments

@kittaakos
Copy link
Contributor

Due to deadlock issues, we have explicitly disabled the parallel (lerna) execution on Windows.

https://github.com/theia-ide/theia/blob/f5cec4444315651c1c583f740adcfeb6bef5a33f/scripts/lerna.js#L24

This is a pain for Windows users. Check whether we can re-enable the parallel execution. It might require bumping up the lerna version.
@kittaakos kittaakos added the OS/Windows issues related to the Windows OS label Mar 12, 2019
kittaakos pushed a commit that referenced this issue Sep 25, 2019
GH-4532: Run lerna in parallel on Windows
d7344d9 
Bumped up dependencies:
 - `lerna` to `3.16.4`,
 - `fs-extra` to `8.1.0`, and
 - `tar` to `4.4.13`.

Adjusted:
 - the typings for `fs-extra` and
 - `resolution` to  `resolutions`.

Closes #4532

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Sep 25, 2019
Closed
1 task
kittaakos pushed a commit that referenced this issue Sep 25, 2019
GH-4532: Run lerna in parallel on Windows
f588767 
Bumped up dependencies:
 - `lerna` to `3.16.4`,
 - `fs-extra` to `8.1.0`, and
 - `tar` to `4.4.13`.

Adjusted:
 - the typings for `fs-extra` and
 - `resolution` to  `resolutions`.

Closes #4532

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jan 16, 2020
GH-4532: Enabled parallel lerna execution on Win32
3d95651 
 - Aug 7, 2017: The parallel execution was bugusly introduced: e8beacc.
 - Nov 9, 2018: The logic was fixed: 5a60919.

`lerna` ran perfecetly without the sequential restriction for a year.
No need to punish Windows users with this build penalty.

This commit reverts e8beacc.

Closes #4532

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Jan 16, 2020
Merged
1 task
kittaakos pushed a commit that referenced this issue Jan 19, 2020
@kittaakos
GH-4532: Enabled parallel lerna execution on Win32
fd2d384 
 - Aug 7, 2017: The parallel execution was bugusly introduced: e8beacc.
 - Nov 9, 2018: The logic was fixed: 5a60919.

`lerna` ran perfecetly without the sequential restriction for a year.
No need to punish Windows users with this build penalty.

This commit reverts e8beacc.

Closes #4532

Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
eclipse-theiaGH-4532: Enabled parallel lerna execution on Win32
526f57b 
 - Aug 7, 2017: The parallel execution was bugusly introduced: e8beacc.
 - Nov 9, 2018: The logic was fixed: 5a60919.

`lerna` ran perfecetly without the sequential restriction for a year.
No need to punish Windows users with this build penalty.

This commit reverts e8beacc.

Closes eclipse-theia#4532

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Windows issues related to the Windows OS
Projects
None yet
Milestone
No milestone
1 participant
@kittaakos