Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] support os specific keybindings #4203

Closed
akosyakov opened this issue Jan 31, 2019 · 0 comments · Fixed by #4205
Closed

[vscode] support os specific keybindings #4203

akosyakov opened this issue Jan 31, 2019 · 0 comments · Fixed by #4205
Assignees
@akosyakov
Labels
bug bugs found in the application extension system issues related to the extension system keybindings issues related to keybindings vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

Some keybindings don't provide general key, but only platform specific, for instance from node-debug:
https://github.com/Microsoft/vscode-node-debug/blob/216e4535513d0fc8368b1b4571b94263a0a4eca0/package.json#L138-L142

It causes runtime errors.
@akosyakov akosyakov added bug bugs found in the application extension system issues related to the extension system keybindings issues related to keybindings vscode issues related to VSCode compatibility labels Jan 31, 2019
@akosyakov akosyakov self-assigned this Jan 31, 2019
@akosyakov akosyakov mentioned this issue Jan 31, 2019
Closed
akosyakov added a commit that referenced this issue Jan 31, 2019
@akosyakov
[vscode] fix #4203: support os specific keybindings
364621f 
Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov mentioned this issue Jan 31, 2019
Merged
akosyakov added a commit that referenced this issue Jan 31, 2019
@akosyakov
[vscode] fix #4203: support os specific keybindings
c9da297 
Signed-off-by: Anton Kosyakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application extension system issues related to the extension system keybindings issues related to keybindings vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] support os specific keybindings eclipse-theia/theia
1 participant
@akosyakov