Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Keybindings and Menu Items #210

Closed
4 tasks
svenefftinge opened this issue Jun 15, 2017 · 2 comments
Closed
4 tasks

Additional Keybindings and Menu Items #210

svenefftinge opened this issue Jun 15, 2017 · 2 comments
Assignees
@kittaakos
Labels
enhancement issues that are enhancements to current functionality - nice to haves
Milestone
Theia BETA

Comments

@svenefftinge
Copy link
Contributor

We should register keybindings and menu items for

  • undo/redo
    Will be tested by opening an editor, applying a change, then undo the change and verify the document’s state. Afterwards ‘redo’ shall reapply the change.
  • find/replace (in editor)
    Will be tested by searching a text phrase in a document.
  • copy/paste (menu only in electron)
    The copy and paste menu actions, will be added to the Electron application’s main menu. It will copy the currently selected text of the focusses text editor into the clip board. ‘Paste’ will insert the text in the system’s clipboard at the cursor position of the currently opened and focussed text editor.
  • selection commands
    The main menu contributions for the selection commands shall have the same effect than the corresponding keybindings.
@svenefftinge svenefftinge added this to the Theia 1.0 BETA milestone Jun 15, 2017
@svenefftinge svenefftinge added the enhancement issues that are enhancements to current functionality - nice to haves label Jun 15, 2017
@svenefftinge svenefftinge mentioned this issue Aug 7, 2017
Closed
@svenefftinge svenefftinge mentioned this issue Aug 25, 2017
Closed
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Restored undo/redo functionality.
87c72be 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Aug 29, 2017
Merged
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Registered find/replace commands and menu items.
16da2cc 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Registered selection commands, handlers and menu items.
9748b0e 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Finalized selection menu and command contributions.
095b56a 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Added accelerators to menu items.
168bbae 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Aug 29, 2017
@kittaakos
GH-210: Added missing accelerator for Select All.
4608411 
This is not an Monaco editor action, hence we need to process it
manually.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Aug 30, 2017
@kittaakos
GH-210: Registered Cut/Copy. Paste is still broken.
07a7fc5 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Sep 1, 2017
Open
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Fixed issue with the paste command in electron.
fad2266 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Restored undo/redo functionality.
b4ed54f 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered find/replace commands and menu items.
43a27d5 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered selection commands, handlers and menu items.
f83dca0 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Finalized selection menu and command contributions.
5e69332 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Added accelerators to menu items.
ad8df77 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Added missing accelerator for Select All.
b0a14b1 
This is not an Monaco editor action, hence we need to process it
manually.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered Cut/Copy. Paste is still broken.
6c7c40b 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Fixed issue with the paste command in electron.
89cdffc 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Restored undo/redo functionality.
2595434 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered find/replace commands and menu items.
46b9c30 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered selection commands, handlers and menu items.
b474d4c 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Finalized selection menu and command contributions.
bd1eb40 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Added accelerators to menu items.
a061920 
Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Added missing accelerator for Select All.
d48d1ac 
This is not an Monaco editor action, hence we need to process it
manually.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Sep 1, 2017
@kittaakos
GH-210: Registered Cut/Copy. Paste is still broken.
8a7491a 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 1, 2017
@kittaakos @akosyakov
GH-210: Fixed issue with the paste command in electron.
ab481f3 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 1, 2017
@kittaakos @akosyakov
GH-210: Fixed issues after the messed-up rebase attempt.
b039076 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 1, 2017
@kittaakos @akosyakov
GH-210: Updated keybindings API. Introduced options argument.
30f19e4 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 1, 2017
@kittaakos @akosyakov
GH-210: Fixed function binding. Updated lock file.
907320b 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Restored undo/redo functionality.
4a348b5 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Registered find/replace commands and menu items.
df369da 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Registered selection commands, handlers and menu items.
acc02f1 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Finalized selection menu and command contributions.
be1b066 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Added accelerators to menu items.
59c9943 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Added missing accelerator for Select All.
69172ea 
This is not an Monaco editor action, hence we need to process it
manually.

Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Registered Cut/Copy. Paste is still broken.
16b6a40 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Fixed issue with the paste command in electron.
e23e0cb 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Fixed issues after the messed-up rebase attempt.
b55e73c 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Updated keybindings API. Introduced options argument.
087ef37 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 5, 2017
@kittaakos @akosyakov
GH-210: Fixed function binding. Updated lock file.
88d85bc 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Restored undo/redo functionality.
ba27a62 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Registered find/replace commands and menu items.
29505f7 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Registered selection commands, handlers and menu items.
d27a739 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Finalized selection menu and command contributions.
28b8b39 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Added accelerators to menu items.
17390d5 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Added missing accelerator for Select All.
c31e26c 
This is not an Monaco editor action, hence we need to process it
manually.

Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Registered Cut/Copy. Paste is still broken.
9409225 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Fixed issue with the paste command in electron.
b09a640 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Fixed issues after the messed-up rebase attempt.
7663328 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Updated keybindings API. Introduced options argument.
97bd556 
Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit that referenced this issue Sep 6, 2017
@kittaakos @akosyakov
GH-210: Fixed function binding. Updated lock file.
c15f707 
Signed-off-by: Akos Kitta <[email protected]>
@akosyakov
Copy link
Member

Done with #437

@svenefftinge svenefftinge modified the milestone: Theia 1.0 BETA Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Milestone
Theia BETA
Development

No branches or pull requests
3 participants
@svenefftinge @kittaakos @akosyakov