Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: unable to execute expressions during a debug session #10648

Closed
vince-fugnitto opened this issue Jan 18, 2022 · 0 comments · Fixed by #10469
Closed

console: unable to execute expressions during a debug session #10648

vince-fugnitto opened this issue Jan 18, 2022 · 0 comments · Fixed by #10469
Labels
bug bugs found in the application console issues related to the console debug issues that related to debug functionality

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Executing expressions during a debug session in the debug console does not work.
The following logs are present:

root ERROR [hosted-plugin: 7831] Unknown request: completions
root ERROR [hosted-plugin: 7831] Unknown request: completions
root ERROR [hosted-plugin: 7831] Unknown request: evaluate
root ERROR [hosted-plugin: 7831] Unknown request: completions
root ERROR [hosted-plugin: 7831] Unknown request: completions
root ERROR [hosted-plugin: 7831] Unknown request: evaluate

theia: executing expressions does not work

theia-expression.mp4

vscode:

vscode-expression.mp4

Steps to Reproduce:

  1. start a debug session (ex: debugging mocha tests) and hit a breakpoint
  2. attempt to execute the expression console.log("hello") in the debug console - nothing happens
@vince-fugnitto vince-fugnitto added bug bugs found in the application debug issues that related to debug functionality console issues related to the console labels Jan 18, 2022
@colin-grant-work colin-grant-work mentioned this issue Jan 26, 2022
Merged
1 task
JonasHelming pushed a commit that referenced this issue Feb 2, 2022
@martin-fleck-at
Properly handle completion and evaluation in debug session (#10469)
a3b025a 
- Ensure console session is disposed when debug session is destroyed
-- Remove  monaco completion item provider on disposal

- Only trigger console session functionality for matching debug session
-- Consider child sessions when searching for valid parents
-- Ensure we provide completion items for our own session
-- Ensure we provide evaluation for our own session

- Sync debug console with the currently selected session

Fixes #10468
Fixes #10648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application console issues related to the console debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly handle debug console completion
1 participant
@vince-fugnitto