[electron] fix resolution of hostname placeholder

Signed-off-by: Anton Kosyakov <[email protected]>
eclipse-theia · May 14, 2020 · f6449af · f6449af
1 parent 8ca3e64
commit f6449af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -33,7 +33,8 @@
         "--no-cluster",
         "--app-project-path=${workspaceRoot}/examples/electron",
         "--remote-debugging-port=9222",
-        "--no-app-auto-install"
+        "--no-app-auto-install",
+        "--plugins=local-dir:../../plugins"
       ],
       "env": {
         "NODE_ENV": "development",
@@ -189,4 +190,4 @@
       ]
     }
   ]
-}
+}
diff --git a/packages/core/src/browser/endpoint.ts b/packages/core/src/browser/endpoint.ts
@@ -52,7 +52,7 @@ export class Endpoint {
         return this.location.pathname;
     }
 
-    protected get host(): string {
+    get host(): string {
         if (this.options.host) {
             return this.options.host;
         }

diff --git a/packages/plugin-ext/src/main/browser/webview/webview-environment.ts b/packages/plugin-ext/src/main/browser/webview/webview-environment.ts
@@ -34,7 +34,8 @@ export class WebviewEnvironment {
         try {
             const variable = await this.environments.getValue(WebviewExternalEndpoint.pattern);
             const value = variable && variable.value || WebviewExternalEndpoint.defaultPattern;
-            this.externalEndpointHost.resolve(value.replace('{{hostname}}', window.location.host || 'localhost'));
+            const { host } = new Endpoint();
+            this.externalEndpointHost.resolve(value.replace('{{hostname}}', host));
         } catch (e) {
             this.externalEndpointHost.reject(e);
         }