Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixes
Browse files Browse the repository at this point in the history
ChayaLau committed Aug 19, 2021
1 parent 18c87d7 commit a0570d4
Showing 4 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -76,6 +76,7 @@
- [debug] `DebugSession` and `PluginDebugSession` constructors accept a `parentSession` of type `DebugSession | undefined` as their 3rd parameter, offsetting every subsequent parameter by one [#9613](https://github.com/eclipse-theia/theia/pull/9613)
- [monaco] upgraded to monaco 0.23.0 including replacement of `quickOpen` API (0.20.x) with `quickInput` API (0.23.x) [#9154](https://github.com/eclipse-theia/theia/pull/9154)
- [workspace] `WorkspaceCommandContribution.addFolderToWorkspace` no longer accepts `undefined`. `WorkspaceService.addRoot` now accepts a `URI` or a `URI[]` [#9684](https://github.com/eclipse-theia/theia/pull/9684)

## v1.15.0 - 6/30/2021

[1.15.0 Milestone](https://github.com/eclipse-theia/theia/milestone/21)
2 changes: 1 addition & 1 deletion packages/core/src/browser/shell/application-shell.ts
Original file line number Diff line number Diff line change
@@ -497,7 +497,7 @@ export class ApplicationShell extends Widget {
const topPanel = new Panel();
topPanel.id = 'theia-top-panel';

// hide top panel when `menuBarVisibility` preference changes
// Hide top panel when the `menuBarVisibility` preference changes.
if (!environment.electron.is()) {
this.corePreferences.onPreferenceChanged(preference => {
if (preference.preferenceName === 'window.menuBarVisibility') {
5 changes: 4 additions & 1 deletion packages/core/src/browser/shell/sidebar-menu-widget.tsx
Original file line number Diff line number Diff line change
@@ -28,7 +28,10 @@ export interface SidebarMenu {
iconClass: string;
title: string;
menuPath: MenuPath;
order: number; // smaller one place lower
/*
* Used to sort menus. The lower the value the lower they are placed in the sidebar.
*/
order: number;
}

/**
1 change: 0 additions & 1 deletion packages/core/src/common/preferences/preference-schema.ts
Original file line number Diff line number Diff line change
@@ -88,7 +88,6 @@ export interface PreferenceDataProperty extends PreferenceItem {
description?: string;
markdownDescription?: string;
scope?: PreferenceScope;
included?: boolean;
}
export namespace PreferenceDataProperty {
export function fromPreferenceSchemaProperty(schemaProps: PreferenceSchemaProperty, defaultScope: PreferenceScope = PreferenceScope.Workspace): PreferenceDataProperty {

0 comments on commit a0570d4

Please sign in to comment.