fix #4776: turn off autoSave by deafult

Signed-off-by: Anton Kosyakov <[email protected]>
eclipse-theia · Apr 2, 2019 · 995d055 · 995d055
1 parent af61268
commit 995d055
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,25 @@ Breaking changes:
 
 - [dialog] `validate` and `accept` methods are now Promisified [#4764](https://github.com/theia-ide/theia/pull/4764)
 
+Breaking changes:
+- [editor] turn off autoSave by default to align with VS Code [#4777](https://github.com/theia-ide/theia/pull/4777)
+  - default settings can be overriden in application package.json:
+  ```json
+  {
+    "private": true,
+    "name": "myapp",
+    "theia": {
+      "frontend": {
+        "config": {
+          "preferences": {
+            "editor.autoSave": "on"
+          }
+        }
+      }
+    }
+  }
+  ```
+
 ## v0.5.0
 
 - Added `scope` to task configurations to differentiate 3 things: task type, task source, and where to run tasks

diff --git a/packages/editor/src/browser/editor-preferences.ts b/packages/editor/src/browser/editor-preferences.ts
@@ -96,8 +96,8 @@ export const editorPreferenceSchema: PreferenceSchema = {
                 'on',
                 'off'
             ],
-            'default': 'on',
-            'description': 'Configure whether the editor should be auto saved.',
+            'default': 'off',
+            'description': 'Controls auto save of dirty files.',
             overridable: false
         },
         'editor.autoSaveDelay': {