8965-hosted-plugin-outfiles

Hosted Plugin debug session contained entire directory of plugin instead of only the out directory containing it - which resulted in performance warning because it would load all files in that directory. Also, added to preferences ability to configure launch `outFiles`. Signed-off-by: Dan Arad <[email protected]>
eclipse-theia · May 25, 2021 · 6262d8c · 6262d8c
1 parent 960a521
commit 6262d8c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/plugin-dev/src/browser/hosted-plugin-manager-client.ts b/packages/plugin-dev/src/browser/hosted-plugin-manager-client.ts
@@ -181,10 +181,12 @@ export class HostedPluginManagerClient {
 
     async startDebugSessionManager(): Promise<void> {
         let outFiles: string[] | undefined = undefined;
-        if (this.pluginLocation) {
+        if (this.pluginLocation && this.hostedPluginPreferences['hosted-plugin.launchOutFiles'].length > 0) {
             const fsPath = await this.fileService.fsPath(this.pluginLocation);
             if (fsPath) {
-                outFiles = [new Path(fsPath).join('**', '*.js').toString()];
+                outFiles = this.hostedPluginPreferences['hosted-plugin.launchOutFiles'].map(outFile =>
+                    outFile.replace('${pluginPath}', new Path(fsPath).toString())
+                );
             }
         }
         await this.debugSessionManager.start({

diff --git a/packages/plugin-dev/src/browser/hosted-plugin-preferences.ts b/packages/plugin-dev/src/browser/hosted-plugin-preferences.ts
@@ -30,13 +30,22 @@ export const HostedPluginConfigSchema: PreferenceSchema = {
             description: 'Using inspect or inspect-brk for Node.js debug',
             default: 'inspect',
             enum: ['inspect', 'inspect-brk']
+        },
+        'hosted-plugin.launchOutFiles': {
+            type: 'array',
+            items: {
+                type: 'string'
+            },
+            description: 'Array of glob patterns for locating generated JavaScript files (`${pluginPath}` will be replaced by plugin actual path).',
+            default: ['${pluginPath}/out/**/*.js']
         }
     }
 };
 
 export interface HostedPluginConfiguration {
     'hosted-plugin.watchMode': boolean;
     'hosted-plugin.debugMode': string;
+    'hosted-plugin.launchOutFiles': string[];
 }
 
 export const HostedPluginPreferences = Symbol('HostedPluginPreferences');