Skip to content

Commit

Permalink
[plugin] fix #6288: dispose webview by a handle, not a widget id
Browse files Browse the repository at this point in the history
Otherwise the webview is not disposed in the plugin host process.

Signed-off-by: Anton Kosyakov <[email protected]>
  • Loading branch information
akosyakov committed Oct 4, 2019
1 parent e3ff100 commit 5e8c3d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/main/browser/webviews-main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class WebviewsMainImpl implements WebviewsMain, Disposable {
this.mouseTracker);
view.disposed.connect(() => {
toDisposeOnClose.dispose();
this.proxy.$onDidDisposeWebviewPanel(viewId);
this.proxy.$onDidDisposeWebviewPanel(panelId);
});
this.toDispose.push(view);

Expand Down

0 comments on commit 5e8c3d8

Please sign in to comment.