Parallel resolve plugin entries

Signed-off-by: Doron Nahari <[email protected]>
eclipse-theia · Jan 27, 2020 · 5abc81d · 5abc81d
1 parent 1ca3ec3
commit 5abc81d
Showing 1 changed file with 17 additions and 8 deletions.
diff --git a/packages/plugin-ext/src/main/node/plugin-deployer-impl.ts b/packages/plugin-ext/src/main/node/plugin-deployer-impl.ts
@@ -20,10 +20,13 @@ import { injectable, optional, multiInject, inject } from 'inversify';
 import {
     PluginDeployerResolver, PluginDeployerFileHandler, PluginDeployerDirectoryHandler,
     PluginDeployerEntry, PluginDeployer, PluginDeployerResolverInit, PluginDeployerFileHandlerContext,
-    PluginDeployerDirectoryHandlerContext, PluginDeployerEntryType, PluginDeployerHandler,
+    PluginDeployerDirectoryHandlerContext, PluginDeployerEntryType, PluginDeployerHandler, PluginDependencies,
 } from '../../common/plugin-protocol';
 import { PluginDeployerEntryImpl } from './plugin-deployer-entry-impl';
-import { PluginDeployerResolverContextImpl, PluginDeployerResolverInitImpl } from './plugin-deployer-resolver-context-impl';
+import {
+    PluginDeployerResolverContextImpl,
+    PluginDeployerResolverInitImpl
+} from './plugin-deployer-resolver-context-impl';
 import { ProxyPluginDeployerEntry } from './plugin-deployer-proxy-entry-impl';
 import { PluginDeployerFileHandlerContextImpl } from './plugin-deployer-file-handler-context-impl';
 import { PluginDeployerDirectoryHandlerContextImpl } from './plugin-deployer-directory-handler-context-impl';
@@ -112,15 +115,21 @@ export class PluginDeployerImpl implements PluginDeployer {
         const visited = new Set<string>();
         const pluginsToDeploy = new Map<string, PluginDeployerEntry>();
 
-        const queue = [...pluginEntries];
+        let queue = [...pluginEntries];
         while (queue.length) {
-            const chunk = [];
+            const dependenciesChunk: PluginDependencies['mapping'][] = [];
+            const workload: string[] = [];
             while (queue.length) {
                 const current = queue.shift()!;
                 if (visited.has(current)) {
                     continue;
+                } else {
+                    workload.push(current);
                 }
                 visited.add(current);
+            }
+            queue = [];
+            await Promise.all(workload.map(async current => {
                 try {
                     const pluginDeployerEntries = await this.resolvePlugin(current);
                     await this.applyFileHandlers(pluginDeployerEntries);
@@ -130,16 +139,16 @@ export class PluginDeployerImpl implements PluginDeployer {
                         if (dependencies && !pluginsToDeploy.has(dependencies.metadata.model.id)) {
                             pluginsToDeploy.set(dependencies.metadata.model.id, deployerEntry);
                             if (dependencies.mapping) {
-                                chunk.push(dependencies.mapping);
+                                dependenciesChunk.push(dependencies.mapping);
                             }
                         }
                     }
                 } catch (e) {
                     console.error(`Failed to resolve plugins from '${current}'`, e);
                 }
-            }
-            for (const dependencies of chunk) {
-                for (const [dependency, deployableDependency] of dependencies) {
+            }));
+            for (const dependencies of dependenciesChunk) {
+                for (const [dependency, deployableDependency] of dependencies!) {
                     if (!pluginsToDeploy.has(dependency)) {
                         queue.push(deployableDependency);
                     }