Fix #9774 Incorrect TreeView item ordering. (#9775)

Signed-off-by: Casey Flynn <[email protected]>
eclipse-theia · Jul 26, 2021 · 59ae8ba · 59ae8ba
1 parent 4431303
commit 59ae8ba
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/plugin-ext/src/plugin/tree/tree-views.ts b/packages/plugin-ext/src/plugin/tree/tree-views.ts
@@ -320,8 +320,7 @@ class TreeViewExtImpl<T> implements Disposable {
         // ask data provider for children for cached element
         const result = await this.treeDataProvider.getChildren(parent);
         if (result) {
-            const treeItems: TreeViewItem[] = [];
-            const promises = result.map(async (value, index) => {
+            const treeItemPromises = result.map(async (value, index) => {
 
                 // Ask data provider for a tree item for the value
                 // Data provider must return theia.TreeItem
@@ -374,11 +373,10 @@ class TreeViewExtImpl<T> implements Disposable {
                     command: this.commandsConverter.toSafeCommand(treeItem.command, toDisposeElement)
                 } as TreeViewItem;
 
-                treeItems.push(treeViewItem);
+                return treeViewItem;
             });
 
-            await Promise.all(promises);
-            return treeItems;
+            return Promise.all(treeItemPromises);
         } else {
             return undefined;
         }