8890-dracula-at-night-theme-failure

Theme Dracula-at-night fails when registering it in Theia because theme colors contain null properties. Fix: removed null and undefined color props from theme colors upon registration. Signed-off-by: Dan Arad <[email protected]>
eclipse-theia · Feb 23, 2021 · 55b7ea6 · 55b7ea6
1 parent 7460e6f
commit 55b7ea6
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/packages/monaco/src/browser/monaco-theming-service.ts b/packages/monaco/src/browser/monaco-theming-service.ts
@@ -118,6 +118,7 @@ export class MonacoThemingService {
                 return;
             }
         }
+        this.cleanEmpty(json.colors);
         return json;
     }
 
@@ -202,4 +203,12 @@ export class MonacoThemingService {
         return str;
     }
 
+    private cleanEmpty(obj: any): void {
+        for (const key in obj) {
+            // eslint-disable-next-line no-null/no-null
+            if ([null, undefined].includes(obj[key])) {
+                delete obj[key];
+            }
+        }
+    }
 }