Skip to content

Commit

Permalink
typos
Browse files Browse the repository at this point in the history
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
  • Loading branch information
colin-grant-work committed Aug 31, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent ac4493b commit 55a7440
Showing 5 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ export interface Breadcrumb {
/** A CSS class for the icon. */
readonly iconClass?: string;

/** CSS classes for the container */
/** CSS classes for the container. */
readonly containerClass?: string;
}

6 changes: 3 additions & 3 deletions packages/core/src/browser/breadcrumbs/breadcrumbs-service.ts
Original file line number Diff line number Diff line change
@@ -49,11 +49,11 @@ export class BreadcrumbsService {
}

/**
* Subscribe to this event emitter to be notifed when the breadcrumbs have changed.
* Subscribe to this event emitter to be notified when the breadcrumbs have changed.
* The URI is the URI of the editor the breadcrumbs have changed for.
*/
get onDidChangeBreadcrumbs(): Event<URI> {
// This lazy subscription is to address problems in iversify's instantiation routine
// This lazy subscription is to address problems in inversify's instantiation routine
// related to use of the IconThemeService by different components instantiated by the
// ContributionProvider.
if (!this.hasSubscribed) {
@@ -63,7 +63,7 @@ export class BreadcrumbsService {
}

/**
* Subscribes to the onDidChangeBreadcrumbs events for all contributions
* Subscribes to the onDidChangeBreadcrumbs events for all contributions.
*/
protected subscribeToContributions(): void {
this.hasSubscribed = true;
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ import { FileStat } from '../../common/files';

export const FilepathBreadcrumbType = Symbol('FilepathBreadcrumb');

export interface FilepathBreadccrumbClassNameFactory {
export interface FilepathBreadcrumbClassNameFactory {
(location: URI, index: number): string;
}

@@ -72,11 +72,11 @@ export class FilepathBreadcrumbsContribution implements BreadcrumbsContribution
.reverse();
}

protected getContainerClassCreator(fileURI: URI): FilepathBreadccrumbClassNameFactory {
protected getContainerClassCreator(fileURI: URI): FilepathBreadcrumbClassNameFactory {
return (location, index) => location.isEqual(fileURI) ? 'file' : 'folder';
}

protected getIconClassCreator(fileURI: URI): FilepathBreadccrumbClassNameFactory {
protected getIconClassCreator(fileURI: URI): FilepathBreadcrumbClassNameFactory {
return (location, index) => location.isEqual(fileURI) ? this.labelProvider.getIcon(location) + ' file-icon' : '';
}

2 changes: 1 addition & 1 deletion packages/monaco/src/browser/monaco-outline-contribution.ts
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ export class MonacoOutlineContribution implements FrontendApplicationContributio
onStart(app: FrontendApplication): void {

// updateOutline and handleCurrentEditorChanged need to be called even when the outline view widget is closed
// in order to udpate breadcrumbs.
// in order to update breadcrumbs.
DocumentSymbolProviderRegistry.onDidChange(
debounce(() => this.updateOutline())
);
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
********************************************************************************/

import { FilepathBreadcrumb } from '@theia/filesystem/lib/browser/breadcrumbs/filepath-breadcrumb';
import { FilepathBreadccrumbClassNameFactory, FilepathBreadcrumbsContribution } from '@theia/filesystem/lib/browser/breadcrumbs/filepath-breadcrumbs-contribution';
import { FilepathBreadcrumbClassNameFactory, FilepathBreadcrumbsContribution } from '@theia/filesystem/lib/browser/breadcrumbs/filepath-breadcrumbs-contribution';
import { inject, injectable } from '@theia/core/shared/inversify';
import { WorkspaceService } from './workspace-service';
import URI from '@theia/core/lib/common/uri';
@@ -26,7 +26,7 @@ export class WorkspaceBreadcrumbsContribution extends FilepathBreadcrumbsContrib
@inject(WorkspaceService)
protected readonly workspaceService: WorkspaceService;

getContainerClassCreator(fileURI: URI): FilepathBreadccrumbClassNameFactory {
getContainerClassCreator(fileURI: URI): FilepathBreadcrumbClassNameFactory {
const workspaceRoot = this.workspaceService.getWorkspaceRootUri(fileURI);
return (location, index) => {
if (location.isEqual(fileURI)) {
@@ -38,7 +38,7 @@ export class WorkspaceBreadcrumbsContribution extends FilepathBreadcrumbsContrib
};
}

getIconClassCreator(fileURI: URI): FilepathBreadccrumbClassNameFactory {
getIconClassCreator(fileURI: URI): FilepathBreadcrumbClassNameFactory {
const workspaceRoot = this.workspaceService.getWorkspaceRootUri(fileURI);
return (location, index) => {
if (location.isEqual(fileURI) || workspaceRoot?.isEqual(location)) {

0 comments on commit 55a7440

Please sign in to comment.