#8755: Apply problem matchers specified by task provider

Signed-off-by: Miro Spönemann <[email protected]>
eclipse-theia · Nov 19, 2020 · 4d25f75 · 4d25f75
1 parent cd85908
commit 4d25f75
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/plugin-ext/src/common/plugin-api-rpc.ts b/packages/plugin-ext/src/common/plugin-api-rpc.ts
@@ -1213,6 +1213,9 @@ export interface TaskDto {
     label: string;
     source?: string;
     scope: string | number;
+    // Provide a more specific type when necessary (see ProblemMatcherContribution)
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    problemMatcher?: any;
     detail?: string;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;

diff --git a/packages/plugin-ext/src/plugin/type-converters.ts b/packages/plugin-ext/src/plugin/type-converters.ts
@@ -705,6 +705,9 @@ export function fromTask(task: theia.Task): TaskDto | undefined {
     const taskDto = {} as TaskDto;
     taskDto.label = task.name;
     taskDto.source = task.source;
+    if (task.problemMatchers) {
+        taskDto.problemMatcher = task.problemMatchers;
+    }
     if ('detail' in task) {
         taskDto.detail = (task as theia.Task2).detail;
     }
@@ -748,7 +751,7 @@ export function toTask(taskDto: TaskDto): theia.Task {
         throw new Error('Task should be provided for converting');
     }
 
-    const { type, label, source, scope, detail, command, args, options, windows, ...properties } = taskDto;
+    const { type, label, source, scope, problemMatcher, detail, command, args, options, windows, ...properties } = taskDto;
     const result = {} as theia.Task;
     result.name = label;
     result.source = source;