Skip to content

Commit

Permalink
plugin: update resolveSystemPlugins default
Browse files Browse the repository at this point in the history
The commit updates the `resolveSystemPlugins` backend application prop
to `false` since it has the better behavior. The flag was initially set
to `true` not to have breaking behavior changes as part of `v1.19.0`.

The prop is used to not resolve system extension-packs and dependencies
at runtime, and instead resolve them at buildtime.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Oct 29, 2021
1 parent 542393e commit 2f92a16
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions doc/Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ Please see the latest version (`master`) for the most up-to-date information. Pl

Introduced in `v1.19.0` was the feature to better support extension-packs which both contribute functionality and reference plugins (by `id`).
The feature works best when there is no runtime plugin resolvement for system (builtin) plugins as it should be done at build time instead.
In order not to change behavior today, the feature is behind an application prop (acting as a flag). If you want to enable better support for
extension-packs and extension-dependencies as builtins the property should be turned off. You can disable the resolvement in your application's
`package.json` like so:
The feature is behind an application property, acting as a flag to enable/disable the feature. If you want to enable better support for
extension-packs and extension-dependencies as builtins the property should be turned off (default). You can enable/disable the resolution of system
plugin dependencies in your application's `package.json` like so:


```json
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class HostedPluginDeployerHandler implements PluginDeployerHandler {
const metadata = this.reader.readMetadata(manifest);
const dependencies: PluginDependencies = { metadata };
// Do not resolve system (aka builtin) plugins because it should be done statically at build time.
const { resolveSystemPlugins = true } = BackendApplicationConfigProvider.get();
const { resolveSystemPlugins = false } = BackendApplicationConfigProvider.get();
if (resolveSystemPlugins || entry.type !== PluginType.System) {
dependencies.mapping = this.reader.readDependencies(manifest);
}
Expand Down

0 comments on commit 2f92a16

Please sign in to comment.