Skip to content

Commit

Permalink
remove preferencechange listener
Browse files Browse the repository at this point in the history
Signed-off-by: Uni Sayo <[email protected]>
  • Loading branch information
uniibu committed Nov 14, 2018
1 parent b9a5ec1 commit 26748ed
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions packages/terminal/src/browser/terminal-widget-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import * as Xterm from 'xterm';
import { proposeGeometry } from 'xterm/lib/addons/fit/fit';
import { inject, injectable, named, postConstruct } from 'inversify';
import { Disposable, Event, Emitter, ILogger, DisposableCollection } from '@theia/core';
import { Widget, Message, WebSocketConnectionProvider, StatefulWidget, isFirefox, MessageLoop, PreferenceChangeEvent, KeyCode } from '@theia/core/lib/browser';
import { Widget, Message, WebSocketConnectionProvider, StatefulWidget, isFirefox, MessageLoop, KeyCode } from '@theia/core/lib/browser';
import { isOSX } from '@theia/core/lib/common';
import { WorkspaceService } from '@theia/workspace/lib/browser';
import { ShellTerminalServerProxy } from '../common/shell-terminal-protocol';
Expand All @@ -29,7 +29,7 @@ import { ThemeService } from '@theia/core/lib/browser/theming';
import { TerminalWidgetOptions, TerminalWidget } from './base/terminal-widget';
import { MessageConnection } from 'vscode-jsonrpc';
import { Deferred } from '@theia/core/lib/common/promise-util';
import { TerminalPreferences, TerminalConfiguration } from './terminal-preferences';
import { TerminalPreferences } from './terminal-preferences';

export const TERMINAL_WIDGET_FACTORY_ID = 'terminal';

Expand Down Expand Up @@ -84,9 +84,6 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
this.title.label = this.options.title || this.TERMINAL;
this.title.iconClass = 'fa fa-terminal';

this.preferences.onPreferenceChanged(e => {
this.onPreferenceChanged(e);
});
if (this.options.destroyTermOnClose === true) {
this.toDispose.push(Disposable.create(() =>
this.term.destroy()
Expand Down Expand Up @@ -435,10 +432,5 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
protected attachCustomKeyEventHandler(): void {
this.term.attachCustomKeyEventHandler(e => this.customKeyHandler(e));
}
protected async onPreferenceChanged(event: PreferenceChangeEvent<TerminalConfiguration>): Promise<void> {
const { preferenceName } = event;
if (preferenceName === 'terminal.enableCopy' || preferenceName === 'terminal.enablePaste') {
this.attachCustomKeyEventHandler();
}
}

}

0 comments on commit 26748ed

Please sign in to comment.