-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
- Loading branch information
1 parent
ea2371b
commit 095a443
Showing
4 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,10 @@ Please see the latest version (`master`) for the most up-to-date information. | |
} | ||
} | ||
}); | ||
``` | ||
``` | ||
- Replace the targets with the ones that are needed for your use case | ||
- Make sure to use `[email protected]`. Theia requires `inversify@^5.0.1` which means that `5.1.1` is compatible, | ||
but your lockfile might reference an older version. | ||
### v1.16.0 | ||
|
@@ -46,7 +48,7 @@ Please see the latest version (`master`) for the most up-to-date information. | |
- Arch Linux: `sudo pacman -S libsecret` | ||
- Alpine: `apk add libsecret-dev` | ||
- It is possible that a `yarn resolution` is necessary for `keytar` to work on older distributions (the fix was added in `1.16.0` by downgrading the dependency version): | ||
```json | ||
"resolutions": { | ||
"**/keytar": "7.6.0", | ||
|
@@ -73,4 +75,3 @@ Please see the latest version (`master`) for the most up-to-date information. | |
"**/webpack": "5.46.0", | ||
} | ||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters