Skip to content

Commit

Permalink
Allow to use HTTP resources for tab title icon
Browse files Browse the repository at this point in the history
Signed-off-by: Vitaliy Gulyy <[email protected]>
  • Loading branch information
vitaliy-guliy committed Sep 27, 2019
1 parent 5e50106 commit 02c5c1d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/plugin-ext/src/plugin/webviews.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,11 @@ export class WebviewPanelImpl implements theia.WebviewPanel {
set iconPath(iconPath: theia.Uri | { light: theia.Uri; dark: theia.Uri }) {
this.checkIsDisposed();
if (URI.isUri(iconPath)) {
this.proxy.$setIconPath(this.viewId, (<theia.Uri>iconPath).path);
if ('http' === iconPath.scheme || 'https' === iconPath.scheme) {
this.proxy.$setIconPath(this.viewId, iconPath.toString());
} else {
this.proxy.$setIconPath(this.viewId, (<theia.Uri>iconPath).path);
}
} else {
this.proxy.$setIconPath(this.viewId, {
light: (<{ light: theia.Uri; dark: theia.Uri }>iconPath).light.path,
Expand Down

0 comments on commit 02c5c1d

Please sign in to comment.