-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release of GDB Adapter #697
Conversation
This release was correct at the time of writing, because I didn't realize that cdt-gdb-vscode was not updating on openvsx. This has since been resolved (see eclipse-cdt-cloud/cdt-gdb-vscode#125 (comment))
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good, we may want to update the version in the label too (see inline comment). What do you think?
src/components/Releases.js
Outdated
@@ -151,7 +151,7 @@ const communityReleases = [ | |||
url: 'https://projects.eclipse.org/projects/ecd.cdt-cloud', | |||
version: '0.0.108', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the version label here too. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I added a new commit. Can you squash them when you merge please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 👍
This release was correct at the time of writing, because I didn't realize that cdt-gdb-vscode was not updating on openvsx. This has since been resolved (see eclipse-cdt-cloud/cdt-gdb-vscode#125 (comment))