Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release of GDB Adapter #697

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

jonahgraham
Copy link
Contributor

This release was correct at the time of writing, because I didn't realize that cdt-gdb-vscode was not updating on openvsx. This has since been resolved (see eclipse-cdt-cloud/cdt-gdb-vscode#125 (comment))

This release was correct at the time of writing, because I didn't realize that cdt-gdb-vscode was not updating on openvsx. This has since been resolved (see eclipse-cdt-cloud/cdt-gdb-vscode#125 (comment))
@jonahgraham
Copy link
Contributor Author

@planger Follow up to #674

@jonahgraham jonahgraham temporarily deployed to pull-request-preview December 28, 2024 15:07 — with GitHub Actions Inactive
Copy link

github-actions bot commented Dec 28, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-12-28 19:22 UTC

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good, we may want to update the version in the label too (see inline comment). What do you think?

@@ -151,7 +151,7 @@ const communityReleases = [
url: 'https://projects.eclipse.org/projects/ecd.cdt-cloud',
version: '0.0.108',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the version label here too. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I added a new commit. Can you squash them when you merge please.

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@planger planger merged commit bceda90 into eclipse-theia:master Dec 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants