-
Notifications
You must be signed in to change notification settings - Fork 27
[cpp-debug] Update cpp debug to use latest debug in Theia #7
[cpp-debug] Update cpp debug to use latest debug in Theia #7
Conversation
Signed-off-by: Rob Moran <[email protected]>
I had an initial look, so far it LGTM. I have not tried to run it yet, I'll do that a little later today. |
dependencies: | ||
"@phosphor/algorithm" "^1.1.2" | ||
|
||
"@phosphor/commands@^1.5.0": | ||
version "1.6.1" | ||
resolved "https://registry.yarnpkg.com/@phosphor/commands/-/commands-1.6.1.tgz#6f60c2a3b759316cd1363b426df3b4036bb2c7fd" | ||
integrity sha512-iRgn7QX64e0VwZ91KFo964a/LVpw9XtiYIYtpymEyKY757NXvx6ZZMt1CqKfntoDcSZJeVte4eV8jJWhZoVlDA== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, any reason to remove all integrity fields ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just a matter of upgrading yarn?
@@ -14,7 +14,7 @@ | |||
"keywords": [ | |||
"theia-extension", "cpp", "debug" | |||
], | |||
"version": "0.3.15", | |||
"version": "0.3.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, shouldn't it be now 0.3.17 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was made before 0.3.17 was released. It might be some additional work bumping to 0.3.17 (maybe the APIs have changed?), so I would be fine with merging this and doing 0.3.16 -> 0.3.17 in another patch.
I was able to run and step in a simple program, which is the most I expect at the moment :). We will really need to work on error handling, because doing anything slightly wrong (as a user) leads to things not working and no, or unclear error messages. |
Great, can someone with the correct rights merge this? I'll upgrade yarn and migrate this to |
Signed-off-by: Rob Moran [email protected]
This PR brings the
cpp debug adapter
up to date with the latest Theia debug infrastructure and fixes #6.Specific changes this adds:
package.json
filepackage.json
.@simark @marechal-p I have only ensured that this builds and correctly adds the configurations.
I have no reason to believe it doesn't work, but could you check with your own examples?