Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

[cpp-debug] Update cpp debug to use latest debug in Theia #7

Merged
merged 1 commit into from
Dec 1, 2018
Merged

[cpp-debug] Update cpp debug to use latest debug in Theia #7

merged 1 commit into from
Dec 1, 2018

Conversation

thegecko
Copy link
Member

@thegecko thegecko commented Nov 28, 2018

Signed-off-by: Rob Moran [email protected]

This PR brings the cpp debug adapter up to date with the latest Theia debug infrastructure and fixes #6.

Specific changes this adds:

@simark @marechal-p I have only ensured that this builds and correctly adds the configurations.
I have no reason to believe it doesn't work, but could you check with your own examples?

@simark
Copy link

simark commented Nov 30, 2018

I had an initial look, so far it LGTM. I have not tried to run it yet, I'll do that a little later today.

dependencies:
"@phosphor/algorithm" "^1.1.2"

"@phosphor/commands@^1.5.0":
version "1.6.1"
resolved "https://registry.yarnpkg.com/@phosphor/commands/-/commands-1.6.1.tgz#6f60c2a3b759316cd1363b426df3b4036bb2c7fd"
integrity sha512-iRgn7QX64e0VwZ91KFo964a/LVpw9XtiYIYtpymEyKY757NXvx6ZZMt1CqKfntoDcSZJeVte4eV8jJWhZoVlDA==
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, any reason to remove all integrity fields ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just a matter of upgrading yarn?

@@ -14,7 +14,7 @@
"keywords": [
"theia-extension", "cpp", "debug"
],
"version": "0.3.15",
"version": "0.3.16",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, shouldn't it be now 0.3.17 ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was made before 0.3.17 was released. It might be some additional work bumping to 0.3.17 (maybe the APIs have changed?), so I would be fine with merging this and doing 0.3.16 -> 0.3.17 in another patch.

@simark
Copy link

simark commented Nov 30, 2018

I was able to run and step in a simple program, which is the most I expect at the moment :).

We will really need to work on error handling, because doing anything slightly wrong (as a user) leads to things not working and no, or unclear error messages.

@thegecko
Copy link
Member Author

thegecko commented Dec 1, 2018

Great, can someone with the correct rights merge this?

I'll upgrade yarn and migrate this to Theia 0.3.17 in a subsequent PR.

@marcdumais-work marcdumais-work merged commit 3c51c52 into eclipse-theia:master Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[theia] Upgrade this repo to use Theia 0.3.16
5 participants