-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watch script to watch all packages at once #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Do you believe watch
should be documented, especially for new developers who are likely to use the generator, or build their own extensions for the first time? @JonasHelming any thoughts?
Yes, I guess we should add it here as a second option alternativly to watching both separatly https://github.com/eclipse-theia/generator-theia-extension/blob/master/templates/README.md#developing-with-the-browser-example |
Thanks for the feedback! Good idea with adding the global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good thank you! Can you please squash so we can merge?
I'm a little confused as to why the docs describe the watch
workflow in such a way where we need to launch the backends with vscode, we can alternatively also describe how to do so simply with the terminal.
I often find myself adding that in Theia-based projects, especially for those that have multiple extensions. Also adds global yarn watch to README template. Signed-off-by: Philip Langer <[email protected]>
Thanks a lot! I force-pushed a single commit with all changes.
I agree that it would make sense to at least also mention that the backend can be started from within VSCode via the launch config or with e.g. |
If you'd like to and agree it adds value for extension developers then please feel free to open the PR :) |
I created a ticket for the follow up so we can merge this for now |
I often find myself adding that in Theia-based projects, especially for those that have multiple extensions.