Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch script to watch all packages at once #82

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

planger
Copy link
Contributor

@planger planger commented Jan 20, 2021

I often find myself adding that in Theia-based projects, especially for those that have multiple extensions.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Do you believe watch should be documented, especially for new developers who are likely to use the generator, or build their own extensions for the first time? @JonasHelming any thoughts?

@JonasHelming
Copy link
Contributor

Yes, I guess we should add it here as a second option alternativly to watching both separatly https://github.com/eclipse-theia/generator-theia-extension/blob/master/templates/README.md#developing-with-the-browser-example

@planger
Copy link
Contributor Author

planger commented Feb 2, 2021

Thanks for the feedback! Good idea with adding the global yarn watch to the README, I made a suggestion in a new commit 0657143 in this PR.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good thank you! Can you please squash so we can merge?

I'm a little confused as to why the docs describe the watch workflow in such a way where we need to launch the backends with vscode, we can alternatively also describe how to do so simply with the terminal.

I often find myself adding that in Theia-based projects, especially for
those that have multiple extensions.

Also adds global yarn watch to README template.

Signed-off-by: Philip Langer <[email protected]>
@planger
Copy link
Contributor Author

planger commented Feb 2, 2021

Thanks a lot! I force-pushed a single commit with all changes.

I'm a little confused as to why the docs describe the watch workflow in such a way where we need to launch the backends with vscode, we can alternatively also describe how to do so simply with the terminal.

I agree that it would make sense to at least also mention that the backend can be started from within VSCode via the launch config or with e.g. cd browser-app; yarn start. Do you want me to open a separate PR with a proposal?

@vince-fugnitto
Copy link
Member

Thanks a lot! I force-pushed a single commit with all changes.

I'm a little confused as to why the docs describe the watch workflow in such a way where we need to launch the backends with vscode, we can alternatively also describe how to do so simply with the terminal.

I agree that it would make sense to at least also mention that the backend can be started from within VSCode via the launch config or with e.g. cd browser-app; yarn start. Do you want me to open a separate PR with a proposal?

If you'd like to and agree it adds value for extension developers then please feel free to open the PR :)

@JonasHelming
Copy link
Contributor

I created a ticket for the follow up so we can merge this for now

@JonasHelming JonasHelming merged commit 9614818 into eclipse-theia:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants