Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cancel the build if Latest fails #129

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Do not cancel the build if Latest fails #129

merged 1 commit into from
Jan 31, 2022

Conversation

JonasHelming
Copy link
Contributor

fixed #128

Signed-off-by: Jonas Helming [email protected]

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasHelming we might want simply split the job in two instead. where their status does not influence the other. It would be easier to identify what failed, and give us two separate CI checks.

@JonasHelming
Copy link
Contributor Author

@JonasHelming we might want simply split the job in two instead. where their status does not influence the other. It would be easier to identify what failed, and give us two separate CI checks.

Agreed, as we also have the basic tests, I went ahead and created three jobs

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once approved I believe we can merge, and confirm that #130 passes.

- name: Generate and Build Templates with Next Theia version
if: always()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we need this anymore?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍
Let's merge and rebase #130, hopefully it will pass :)

@JonasHelming JonasHelming merged commit 7419b7a into master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not cancel the build when "Latest" fails
2 participants