Fix tree editor dependency for Theia 1.18+ #118
Conversation
Use next instead of latest version as latest is currently not published regularly. The current latest version is not compatible with Theia 1.18 while the next version is. Signed-off-by: Lucas Koehler <[email protected]>
| @@ -200,7 +200,7 @@ module.exports = class TheiaExtension extends Base { | |||
| this.params.dependencies = ''; | |||
| this.params.browserDevDependencies = ''; | |||
| if (this.params.extensionType === ExtensionType.TreeEditor) { | |||
| this.params.dependencies = `,\n "@theia/editor": "${this.params.theiaVersion}",\n "@theia/filesystem": "${this.params.theiaVersion}",\n "@theia/workspace": "${this.params.theiaVersion}",\n "@eclipse-emfcloud/theia-tree-editor": "latest",\n "uuid": "^3.3.2"`; | |||
| this.params.dependencies = `,\n "@theia/editor": "${this.params.theiaVersion}",\n "@theia/filesystem": "${this.params.theiaVersion}",\n "@theia/workspace": "${this.params.theiaVersion}",\n "@eclipse-emfcloud/theia-tree-editor": "next",\n "uuid": "^3.3.2"`; | |||
There was a problem hiding this comment.
I believe using a mismatch of latest and next will cause issues (especially for inversify) as it can potentially pull different versions of the same extension (ex: @theia/core).
In addition, if a user passes --theia-version on the command line while generating the extension it will not work well either:
$ yo theia-extension --theia-version=1.17.0There was a problem hiding this comment.
Thanks for the quick feedback @vince-fugnitto :)
I agree that this is not an optimal solution but more of a temporary solution until there are regular numbered releases (or RCs) of the tree editor. As of now there aren't any and the latest tag is currently not updated because there was no release CQ done, yet.
In the current state, the tree extension does not work at all with Theia 1.18.0 (or any Theia version since the switch to ECMA2017).
For the moment, I see two possible solutions: Set it to next or set it to a specific version (0.7.0-next.0324b32).
In addition, if a user passes --theia-version on the command line while generating the extension it will not work well either:
I think this will be a general problem even if using latest because the user can always put in a Theia version that is too old. To fix this, we'd need to pass in or derive a separate version for the tree. I think this is a separate issue to the current one.
What do you think?
There was a problem hiding this comment.
I also think this reveals a general issue: #119
|
@JonasHelming did you need me to publish a new version of the generator with the fix? Is there anything else you'd like fixed before we are to do another release? |
|
Yes, please, the only open PR will need more time to fix upstream issues |
@JonasHelming a new version |
Use next instead of latest version as latest is currently not published regularly.
The current latest version is not compatible with Theia 1.18 while the next version is.
Signed-off-by: Lucas Koehler [email protected]