Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use constructor injection #216

Closed
tsmaeder opened this issue Oct 8, 2024 · 0 comments · Fixed by #220
Closed

Don't use constructor injection #216

tsmaeder opened this issue Oct 8, 2024 · 0 comments · Fixed by #220

Comments

@tsmaeder
Copy link

tsmaeder commented Oct 8, 2024

The generated extension uses constructor injection (See HelloWorldCommandContribution). The coding guidelines recommend property injection.
JonasHelming added a commit that referenced this issue Oct 8, 2024
@JonasHelming
Use property injection
bf0b006 
fixed #216

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use property injection eclipse-theia/generator-theia-extension
1 participant
@tsmaeder