Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rimraf with shx #404

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Replace rimraf with shx #404

merged 3 commits into from
Nov 15, 2023

Conversation

kaisalmen
Copy link
Contributor

shx is the command-line util of shelljs which is already a dependency of yeoman-generator
I just realized rimraf was updated again after a long pause. Now shelljs is moving slow, but there still seems to be activity.

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I noticed that generator-sprotty doesn't produce any output, and I don't see why. Could you have a look?

@kaisalmen
Copy link
Contributor Author

I noticed that generator-sprotty doesn't produce any output, and I don't see why. Could you have a look?

I will

@kaisalmen
Copy link
Contributor Author

kaisalmen commented Nov 10, 2023

Fixed: Clean in generator-sprotty did not delete *.tsbuildinfo

I have remove package level build, watch and test scripts, too. Is this too radical? Performance wise this is not a problem. The question is if peoplefrom now on will use something else then the top-level ones. My experience from other projects is that I usually don't. But that is only my opinion. 😊 WDYT?

We no longer require skipLibCheck therefore the FP ⬇️

@spoenemann
Copy link
Contributor

If we can keep the package-level scripts at no cost, I think we should do that. They may not be used frequently, but it can still be useful to have them.

@kaisalmen
Copy link
Contributor Author

Done!

@dhuebner dhuebner merged commit 28dc7b8 into master Nov 15, 2023
2 checks passed
@dhuebner
Copy link
Contributor

@kaisalmen @spoenemann
Works well for me!

@spoenemann spoenemann deleted the replace-rimraf branch November 16, 2023 13:40
@spoenemann spoenemann added this to the v1.1.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants