-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch all sprotty packages with a single command from root #394
watch all sprotty packages with a single command from root #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to switch to compiling with a TypeScript workspace like it's done in Langium:
https://github.com/eclipse-langium/langium/blob/main/tsconfig.build.json
Then building or watching the whole workspace can be done with a single tsc -b tsconfig.build.json
call (add -w
or --watch
for watching). The only part where we'd still need concurrently
is to bundle the examples with Webpack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We also need to add references
to reflect the dependencies between packages. See how it's done in Langium:
https://github.com/eclipse-langium/langium/blob/9b177376c01b0e2c69cdbd82f5fc07b2e1d4577c/packages/langium-cli/tsconfig.src.json#L7-L9
sprotty has a dependency to sprotty-protocol and sprotty-elk has a dependency to both sprotty and sprotty-protocol.
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
b191825
to
80f841c
Compare
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! A few more things to top this off:
- Remove packages/generator-sprotty/tsconfig.tsbuildinfo
- Remove the "prepare" script from all packages and examples
- Change the root "prepare" script to
yarn run clean && yarn run build
@spoenemann why do we do that? |
Signed-off-by: Jonah Iden <[email protected]>
For convenience, I guess. So far, it has never got in my way (It's been like this since 2017). But I'm ok with changing that for consistency with other project. But then we also need to adapt .gitpod.yml and the GitHub action workflows. |
@kaisalmen feel free to do that change in another PR. |
…protty#394) Signed-off-by: Jonah Iden <[email protected]>
added a new watch task to the root package json to watch all packages concurrently