Improve the event processors #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbegaudeau
force-pushed
the
sbe/enh/reactor
branch
3 times, most recently
from
7eed6ad to
c73f675
Compare
pcdavid
reviewed
Mar 8, 2021
...ams/src/main/java/org/eclipse/sirius/web/spring/collaborative/diagrams/DiagramEventFlux.java
Outdated
Show resolved
Hide resolved
pcdavid
reviewed
Mar 8, 2021
...rc/main/java/org/eclipse/sirius/web/spring/collaborative/forms/PropertiesEventProcessor.java
Show resolved
Hide resolved
pcdavid
reviewed
Mar 9, 2021
...in/java/org/eclipse/sirius/web/spring/collaborative/representations/SubscriptionManager.java
Outdated
Show resolved
Hide resolved
pcdavid
reviewed
Mar 9, 2021
pcdavid
reviewed
Mar 9, 2021
.../java/org/eclipse/sirius/web/spring/collaborative/projects/EditingContextEventProcessor.java
Outdated
Show resolved
Hide resolved
pcdavid
reviewed
Mar 9, 2021
.../org/eclipse/sirius/web/spring/collaborative/projects/RepresentationEventProcessorEntry.java
Show resolved
Hide resolved
pcdavid
reviewed
Mar 9, 2021
...g/eclipse/sirius/web/spring/collaborative/projects/EditingContextEventProcessorRegistry.java
Outdated
Show resolved
Hide resolved
pcdavid
reviewed
Mar 9, 2021
...g/eclipse/sirius/web/spring/collaborative/projects/EditingContextEventProcessorRegistry.java
Outdated
Show resolved
Hide resolved
pcdavid
requested changes
Mar 9, 2021
Comment on lines
50
to
53
| var subscriptionCount = this.username2subscriptionCount.getOrDefault(username, new AtomicInteger()); | ||
| subscriptionCount.getAndIncrement(); | ||
|
|
||
| this.username2subscriptionCount.put(username, subscriptionCount); |
There was a problem hiding this comment.
Actually re-reading this I think this is not thread-safe either. From the initial state, two threads can enter add, both calling getOrDefaultwill return 2 AtomicInteger, increment them both to 1, and both but 1 into the map. The last one to call put will "win" but we still end with 1 for this username.
I think we should use ConcurrentMap.computeIfAbsent() instead of getOrDefault and then put to atomically get/initialize the AtomicInteger and then atomically mutate it.
Same logic for remove.
pcdavid
approved these changes
Mar 9, 2021
Bug: #367 Signed-off-by: Stéphane Bégaudeau <[email protected]>
Bug: #368 Signed-off-by: Stéphane Bégaudeau <[email protected]>
Signed-off-by: Stéphane Bégaudeau <[email protected]>
This first commit will make sure that the disposal of the representation event processors do not rely on SubscriptionDescription anymore. Thanks to this commit it will be possible to remove the SubscriptionDescription during the retrieval of the payload flux and then to update the lifecycle of the APIs used to disposed the representations event processors. Bug: #357 Signed-off-by: Stéphane Bégaudeau <[email protected]>
Bug: #357 Signed-off-by: Stéphane Bégaudeau <[email protected]>
…tion event processors Bug: #357 Signed-off-by: Stéphane Bégaudeau <[email protected]>
Signed-off-by: Stéphane Bégaudeau <[email protected]>
Bug: #268 Signed-off-by: Stéphane Bégaudeau <[email protected]>
- Remove useless code in the dipose since no one is present anymore to receive complete events - Use SLF4J native formatting capabilities instead of MessageFormat - Improve the thread safety of the subscription manager Signed-off-by: Stéphane Bégaudeau <[email protected]>
Bug: #377 Signed-off-by: Stéphane Bégaudeau <[email protected]>
Signed-off-by: Stéphane Bégaudeau <[email protected]>
sbegaudeau
force-pushed
the
sbe/enh/reactor
branch
from
2c22f4f to
0239300
Compare
This was
linked to
issues
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.