PR to fix the wrong border node location creation problem 2 #434
+1,111
−980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRAFT: No fully sure of the impact of added test in the subclasses. Must be verify after merged. Bug: eclipse-sirius#396
Remove parameter in private method that is always true.
Code has leftovers after some refactoring.
Such nodes may be border nodes. They require layout data on container to be placed.
|
The cleanup commits have been copied into PR #455. A slightly different approach has been chosen in the PR #455 instead of the commit "[396] Add LayoutData when creating node in Stack Container." proposed in the current PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #396
Complement of #404.
Draft :
org.eclipse.sirius.tests.swtbot.BorderedNodeCreationTest#testBNC_OnVStackContainer() is still failing but
with
expected:<Point(393.0, 445.0)> but was:<Point(384.0, 410.0)>instead of
expected:<Point(393.0, 445.0)> but was:<Point(153.0, 326.0)>The shift may come from the assertion targeting the wrong container.