Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge label is not displayed at the same location when changing the diagram zoom level #4

Open
lfasani opened this issue Jul 4, 2023 · 5 comments
Assignees
Labels
component: diagrams type: bug Something isn't working

Comments

@lfasani
Copy link
Contributor

lfasani commented Jul 4, 2023

With a manhattan edge if the label anchor is exactly at a bendpoint (for example the border of a vertical edge segment next to a horizontal), when changing the zoom, the point calculation may change and then the edge label is displayed in the bad coordinate system.
We need GMF-Runtime changes to have better point precision.

@lfasani lfasani self-assigned this Jul 4, 2023
@lfasani lfasani added this to the v7.2.1 milestone Jul 4, 2023
@pcdavid pcdavid added type: bug Something isn't working component: diagrams labels Jul 5, 2023
@lfasani
Copy link
Contributor Author

lfasani commented Sep 5, 2023

change in GMF-runtime eclipse-gmf-runtime/gmf-runtime@b4316c6

@lfasani
Copy link
Contributor Author

lfasani commented Sep 5, 2023

We should have a reproducible use case in Sirius(currently, we have only a Capella scenario)

@pcdavid
Copy link
Member

pcdavid commented Sep 8, 2023

Fixed in GMF Runtime 1.16.1, and Sirius Desktop 7.2.1 depends on that.

@pcdavid pcdavid closed this as completed Sep 8, 2023
@scosta-obeo
Copy link
Contributor

We should have a reproducible use case in Sirius(currently, we have only a Capella scenario)

Here's a reproduction/validation case: test-bug-edge-label.zip

@scosta-obeo
Copy link
Contributor

I reopen this issue, it doesn't work.

Step to reproduce:

  • Import test-bug-edge-label.zip
  • Open the diagram new DTestBugLabelEdge
  • Zoom to 100%
  • Zoom to 75% or 125%
  • KO: the label has moved (Compared to 100% zoom)

@scosta-obeo scosta-obeo reopened this May 2, 2024
scosta-obeo added a commit that referenced this issue May 2, 2024
@scosta-obeo scosta-obeo modified the milestones: v7.2.1, v7.4.1 May 2, 2024
scosta-obeo added a commit that referenced this issue May 3, 2024
scosta-obeo added a commit that referenced this issue May 6, 2024
@pcdavid pcdavid modified the milestones: v7.4.1, v7.4.2, v7.4.3 Jun 19, 2024
@pcdavid pcdavid modified the milestones: v7.4.3, v7.4.4 Aug 30, 2024
@pcdavid pcdavid modified the milestones: v7.4.4, v7.4.5 Sep 26, 2024
@pcdavid pcdavid modified the milestones: v7.4.5, v7.4.6 Nov 14, 2024
@pcdavid pcdavid removed this from the v7.4.6 milestone Dec 6, 2024
@pcdavid pcdavid added this to the Next maintenance milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagrams type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants