New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-4915 Fixed setting parent in ValueExprTripleRef#replaceChildNode #4916

Merged

hmottestad merged 1 commit into eclipse-rdf4j:main from frensjan:GH-4915-set-parent-in-ValueExprTripleRef

Feb 20, 2024

Contributor

frensjan commented Feb 20, 2024

GitHub issue resolved: #4915

Briefly describe the changes proposed in this PR:

ValueExprTripleRef#replaceChildNode now sets itself as parent on the replacement.

PR Author Checklist (see the contributor guidelines for more details):

my pull request is self-contained
I've added tests for the changes I made
I've applied code formatting (you can use mvn process-resources to format from the command line)
I've squashed my commits where necessary
every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change


          eclipse-rdf4jGH-4915 Fixed setting parent in ValueExprTripleRef#repla…

fa9496b

…ceChildNode

frensjan mentioned this pull request

IllegalStateException Node has no parent from ValueExprTripleRef #4915

Closed

Contributor

hmottestad commented Feb 20, 2024

Looks good. Thanks!

hmottestad merged commit c259fdf into eclipse-rdf4j:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet