-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-2192 upgrade jsonld-java and jackson + fix for test #2233
GH-2192 upgrade jsonld-java and jackson + fix for test #2233
Conversation
It seems to fail randomly on the Jenkins machine (or perhaps JDK13), I'll have to check again. It's probably good idea to wait for the release of Jackson 2.10.5 anyway, since there is an annoying JSON allow-missing-value bug (FasterXML/jackson-core#616) |
Issue in compliance test .ElasticsearchSailGeoSPARQLTest, snakeyaml dependency, could be due to different jackson versions used by elasticsearch-x-content |
c36c541
to
dacefbb
Compare
ef0a422
to
0eae80c
Compare
Unfortunately it looks as if excluding the older version does not work - at least locally for me it doesn't. I've pushed the original fix you had in mind, which is to include the newer version as an explicit (test) dependency. |
Argh that's annoying. I've started using the |
...and it also looks as if I don't have editing rights on your fork Bart. |
I've created a pull request on your fork to resolve this. Fedict#10. I'm sure there must an easier way but my Sunday-brain won't let me think of it. |
Thanks @jeenbroekstra , original idea appears indeed the only one that works. Other attempts did often work once on my local machine, but re-running clean install -P verify failed on a second run ... I'd suggest to use Snakeyaml 1.25, since there is already a CQ21086 for it |
Signed-off-by:Bart Hanssens <[email protected]>
c5a42dc
to
eccab2a
Compare
GitHub issue resolved: #2192
Briefly describe the changes proposed in this PR:
PR Author Checklist:
Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.