Externalize character chains

[mypsycho]

After a first pass to separate externalizable chains from the others by adding NON-NLS tags, about 1000 chains needs externalization.

About mwe2 generation,
there is no option to include //NON-NLS tag
but eclipse error/warning can be toggle off in "Java Build Path" cfg.

How to
To ensure no local String is used 2 tools are needed:

• Detection: sets at project level Properties:java / compiler / errors/Warnings : non-externalized strings = error
• Fix: Launch <ctxt>/source/Externalized String to create properties files once all technical string are escaped.

[mypsycho]

Action to perform

• For each project:
  • Fix plugin.xml
    • Open plugin.xml and launch "Externalize Strings Wizard" (Overview/exporting)
    • Verify keys and apply
  • On each java package
    • For string concatenation, use "Quick Fix (Ctrl+1)/Convert to MessageFormat".
    • Evaluate if a String is technical (non nls) or displayed (nls)
    • Launch "Source/Externalize Strings"
  • Once all package updated, enable verification:
    • in Properties:java / compiler / errors/Warnings
    • set non-externalized strings = error

Progress

• org.eclipse.poosl.model
  • plugin.xml
  • java classes externalized
  • Error detected
• org.eclipse.poosl.model.edit
  • plugin.xml
  • java classes externalized
  • Error detected
• org.eclipse.poosl.model.editor
  • plugin.xml
  • java classes externalized
  • Error detected
• org.eclipse.poosl.pooslproject
  • plugin.xml
  • java classes externalized: 20 items
  • Error detected
• org.eclipse.poosl.rotalumisclient
  • plugin.xml
  • java classes externalized: 337 items
  • Error detected
• org.eclipse.poosl.sirius
  • plugin.xml
  • odesign (use % in labels)
  • java classes externalized: 205 items
  • Error detected
• org.eclipse.poosl.transformations
  • plugin.xml
  • java classes externalized: 18 items
  • Error detected
• org.eclipse.poosl.xtext
  • plugin.xml
  • java classes externalized: 161 items
  • Error detected
• org.eclipse.poosl.xtext.ide
  • plugin.xml
  • java classes externalized
  • Error detected
• org.eclipse.poosl.xtext.ui
  • plugin.xml
  • java classes externalized: 271 items
  • Error detected

[mypsycho]

Special case

org.eclipse.poosl.xtext.custom.FormattingHelper is a major problem for i18n.

It mixes technical StringBuilding (like method signature) and user messages.

Complete reengineering is required:

• detecte use-case.
• sort technical usage from display usage.
• refactor each string build.

Direct usage :

• org.eclipse.poosl.sirius.services.ClassDiagramServices
• org.eclipse.poosl.transformations.poosl2html.Poosl2Html
• org.eclipse.poosl.xtext.descriptions.PooslDataMethodDescription
• org.eclipse.poosl.xtext.descriptions.PooslProcessMethodDescription
• org.eclipse.poosl.xtext.validation.PooslJavaValidatorAcyclicRelations
• org.eclipse.poosl.xtext.validation.PooslJavaValidatorMisc
• org.eclipse.poosl.xtext.validation.PooslJavaValidatorMisc
• org.eclipse.poosl.xtext.ui.contentassist.PooslProposalProviderLabel
• org.eclipse.poosl.xtext.ui.labeling.PooslLabelProvider
• org.eclipse.poosl.xtext.ui.outline.PooslOutlineTreeProvider
• org.eclipse.poosl.xtext.ui.quickfix.PooslQuickfixProviderTypes

It should only be used for formatting model: expected result should be everything is non-nls